feat(mag_calibration): always use WMM if possible#26912
Closed
Conversation
💡 Commit messages could be improvedNot blocking, but these commit messages could use some cleanup.
See the commit message convention for details. This comment will be automatically removed once the issues are resolved. |
bresch
changed the title
❌ PR title needs conventional commit formatExpected format: Your title:
Suggested fix:
To fix this: click the ✏️ next to the PR title at the top of this page and update it. See CONTRIBUTING.md for details. This comment will be automatically removed once the issue is resolved. |
Member
Author
|
Closing as it apparently gives worse results if the actual field is too far from the WMM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
When the raw mag data has relatively large scale factors, the sphere fit returns a radius smaller than the true magnetic field norm. This lead to a sub-optimal ellipsoid fit.
Solution
if the mag field strength can be obtained through the WMM, use it to perform the ellipsiod fit.
Changelog Entry
For release notes: